Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please extract webpack-related things from @storybook/core #4371

Closed
hulkish opened this issue Oct 11, 2018 · 1 comment
Closed

Please extract webpack-related things from @storybook/core #4371

hulkish opened this issue Oct 11, 2018 · 1 comment

Comments

@hulkish
Copy link

hulkish commented Oct 11, 2018

Problem

@storybook/core has an extensive transitive dependency footprint. Much of this comes from bundle related tooling such as webpack.

Use Case

I think there should be a more concise break up of dependencies from @storybook/core for dependencies related to bundling

For example, what if you want to enforce managing only a single version of webpack and the adjacent dependencies that work alongside webpack?

Right now, that's not possible.

Suggestion

  • Extract webpack-related dependencies & code into a package of its own (perhaps @storybook/core-webpack?)

  • Force storybook users to define what webpack package they want to use. While also demanding that the package is compliant with the interface which @storybook/core expects.

  • This will allow for far less overhead to live inside core and allow users to be more powerful with storybook

  • A cleaner way of managing these dependencies

  • Then, i could make my own approach of @storybook/core-webpack which leveraging my app-level tooling instead of having to support an additional webpack version - as well as lifting some of this maintenance overhead from storybook.

  • An added bonus: offload some webpack compatibility concerns by allowing users a way to easily take real full control over the tooling. For ex, issues like this would go away: Storybook default webpack config does not support CRA v2 w/ CSS modules #4306

@valentinpalkovic
Copy link
Contributor

Not relevant anymore. @storybook/core was replaced by @storybook/core-client and @storybook/core-server. Both packages don't rely on e.g. webpack anymore. The whole architecture changed in the meantime. Separate builders were created to support different builders (webpack 4, webpack 5, vite). Therefore, closing this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants