Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking knobs button doesn't work #6546

Closed
sibbl opened this issue Apr 17, 2019 · 2 comments
Closed

Clicking knobs button doesn't work #6546

sibbl opened this issue Apr 17, 2019 · 2 comments
Labels

Comments

@sibbl
Copy link

sibbl commented Apr 17, 2019

I'd like to use a button knob to change a props I pass to the component I want to present.

I followed the sample given here: https://storybooks-official.netlify.com/?path=/story/addons-knobs-withknobs--triggers-actions-via-button

Unfortunately, both the official sample and my local trigger the method I passed.

Your sample is expected to change anything when clicking the "Toggle item list state" button, but the view doesn't change at all. Nothing's rerendered, although I'd expect it to be rerendered with updated props.

Link to sample code of the story which I've also tested locally in different browsers: https://github.com/storybooks/storybook/blob/59e4d06ad24c22825db5c22925873eb40a819793/examples/official-storybook/stories/addon-knobs.stories.js#L291-L308

All other input fields work fine.

System:

  • OS: Windows 10 build 18362.53
  • Device: MS Surface Pro (neither clicking the button via mouse, touch or pen does work)
  • Browser: Chrome, Edge, Firefox
  • Framework: React
  • Addons: knobs
  • Version: 5.0.8 (locally) and 5.0.9 (the version your netlify docs use)
@sibbl sibbl changed the title Changing values by knobs button doesn't work anymore Clicking knobs button doesn't work Apr 17, 2019
@stale
Copy link

stale bot commented May 8, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 8, 2019
@stale
Copy link

stale bot commented Jun 7, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jun 7, 2019
This was referenced Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant