Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always removes one preset from users .babelrc #183

Closed
witnessmenow opened this issue May 10, 2016 · 2 comments
Closed

Always removes one preset from users .babelrc #183

witnessmenow opened this issue May 10, 2016 · 2 comments

Comments

@witnessmenow
Copy link
Contributor

Using 1.24.0 I am unable to run storybook, I get parsing errors.

I've looked into and it is removing the last preset from my babelrc file.
This is occurring in the function "removeReactHmre" in server/config.js it was using -1 to splice.

I'll submit a PR now
witnessmenow added a commit to sevenleaps/react-storybook that referenced this issue May 10, 2016
@witnessmenow
Fix for storybookjs#183 - issue with removing a preset from users bab…
3fd60c4 
…elrc
@timkindberg
Copy link
Contributor

I was just about to fix this too :) it's definitely breaking things

@timkindberg timkindberg mentioned this issue May 10, 2016
Closed
@arunoda
Copy link
Member

arunoda commented May 10, 2016

A Fix for this is landed in v1.25.0.

@arunoda arunoda closed this as completed May 10, 2016
@Bhanditz Bhanditz mentioned this issue Jun 23, 2022
Open
@lili2311 lili2311 mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arunoda @timkindberg @witnessmenow