Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not scrolling in full screen mode on iOS #1227

Closed
plumbblake opened this issue Jun 8, 2017 · 5 comments
Closed

Not scrolling in full screen mode on iOS #1227

plumbblake opened this issue Jun 8, 2017 · 5 comments

Comments

@plumbblake
Copy link

plumbblake commented Jun 8, 2017

The iframe is not scrolling on iOS. this could be fixed by setting its parent to overflow: auto and -webkit-overflow-scrolling: touch

potentially modifying the following object in /lib/ui/src/modules/ui/components/layout/index.js as seen below.

const fullScreenPreviewStyle = {
  position: 'fixed',
  left: '0px',
  right: '0px',
  top: '0px',
  zIndex: 1,
  backgroundColor: '#FFF',
  height: '100%',
  width: '100%',
  border: 0,
  margin: 0,
  padding: 0,
  overflow: 'auto',
  webkitOverflowScrolling: 'touch',
};
@tmeasday
Copy link
Member

tmeasday commented Jun 9, 2017

Hi @plumbblake -- am I correct in saying this is not React Native, but a vanilla React storybook viewed on iOS?

@plumbblake
Copy link
Author

@tmeasday That is correct.

@plumbblake plumbblake changed the title Not scrolling in full screen mode on IOS Not scrolling in full screen mode on iOS Jun 9, 2017
@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale
Copy link

stale bot commented Nov 29, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Nov 29, 2017
@Sandstedt
Copy link

This is still an issue, but not just in fullscreen mode, but also in the default viewing mode.

A quick and dirty fix is to att a file called manager-head.html in the .storybook folder and put this dirty css in it:

<style>
  /* Make the iframe scroll on iOS */

  .Pane.horizontal.Pane1>div>div+div {
    overflow: auto;
    -webkit-overflow-scrolling: touch;
  }
</style>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants