Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using getstorybook on Storybook 2.x repo #1378

Closed
7 tasks
usulpro opened this issue Jun 28, 2017 · 5 comments
Closed
7 tasks

Using getstorybook on Storybook 2.x repo #1378

usulpro opened this issue Jun 28, 2017 · 5 comments
Labels
bug cleanup Minor cleanup style change that won't show up in release changelog cli help wanted inactive

Comments

@usulpro
Copy link
Member

usulpro commented Jun 28, 2017

The most convenient way to migrate from Storybook 2.x to Storybook 3.x is to run getstorybook as it mention in our MIGRATION.md
It works fine but there are some issues left. Fixing them we could make migration process even more comfortable for users.

How to reproduce

git clone https://github.com/sm-react/storybook-adk.git -b storybook_2.x
cd storybook-adk/
git checkout -b migration_test
npm i @storybook/cli -g
getstorybook
npm start

It´ll throw errors which should be solved manually. So the issues are:

  • Doesn´t insert caret (^) in package.json. e.g.:
"@storybook/addon-knobs": "3.1.6",
"@storybook/react": "3.1.7",

expected:

"@storybook/addon-knobs": "^3.1.6",
"@storybook/react": "^3.1.7",
  • Left "@kadira/storybook": "^2.33.1" in peerDependencies

expected:

change to the latest @storybook/react package

  • Left "@kadira/storybook-addons": "^1.6.1" in dependencies

  • Left "@kadira/react-storybook-addon-info": "^3.3.0"

  • Left "@kadira/storyshots": "^2.1.0"

  • Creates import infoAddon from '@storybook/react-addon-info'; instead of @storybook/addon-info

  • Doesn't procces *.jsx files

@usulpro usulpro added bug cleanup Minor cleanup style change that won't show up in release changelog cli help wanted labels Jun 28, 2017
@janusch
Copy link

janusch commented Jul 20, 2017

Hey,
there is a slight confusion about the addon-info package.
I just ran the latest getstorybook command and it rewrote the addon-info imports to:
import infoAddon from '@storybook/react-addon-info';
whereas the package states that it has moved to import infoAddon from '@storybook/addon-info';
See: https://github.com/storybooks/react-storybook-addon-info

Is this the correct package? import infoAddon from '@storybook/addon-info';

Thank you in advance for clarification!

@usulpro
Copy link
Member Author

usulpro commented Jul 20, 2017

@janusch the right name of this package is @storybook/addon-info
See: https://github.com/storybooks/storybook/tree/master/addons/info

@janusch
Copy link

janusch commented Jul 24, 2017

thanks a lot for the reply!

@stale
Copy link

stale bot commented Nov 14, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 14, 2017
@stale
Copy link

stale bot commented Nov 29, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup Minor cleanup style change that won't show up in release changelog cli help wanted inactive
Projects
None yet
Development

No branches or pull requests

2 participants