Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dependencies.io for dependencies management #1920

Merged
merged 2 commits into from Sep 30, 2017
Merged

Use dependencies.io for dependencies management #1920

merged 2 commits into from Sep 30, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Sep 30, 2017 •
edited

Please be prepared to a bunch of PRs after merging this (see https://github.com/Hypnosphi/storybook/pulls). They will be assigned to me though =D

@Hypnosphi Hypnosphi added dependencies maintenance User-facing maintenance tasks labels Sep 30, 2017
@codecov
Copy link

codecov bot commented Sep 30, 2017 •
edited

Codecov Report

Merging #1920 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   21.43%   21.43%           
=======================================
  Files         261      261           
  Lines        5743     5743           
  Branches      685      694    +9     
=======================================
  Hits         1231     1231           
- Misses       3978     3981    +3     
+ Partials      534      531    -3
Impacted Files Coverage Δ
lib/ui/src/modules/ui/containers/left_panel.js 25.71% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fdfc7...d62d568. Read the comment docs.

ndelangen
ndelangen reviewed Sep 30, 2017
View reviewed changes
dependencies.yml
@@ -0,0 +1,57 @@
collectors:

# Temporarily disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be enabled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, can you say why it's disabled and what needs to happen to enable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the tarballs cause the problem here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Hypnosphi#5
Enabling it requires some changes in dependencies.io components

@ndelangen
Copy link
Member

Please wait for #1908 to be merged

@ndelangen
Copy link
Member

OK, here goes nothing..

@Hypnosphi
Copy link
Member Author

OK, I hope our CI will survive this

@Hypnosphi Hypnosphi merged commit 63e82ac into storybookjs:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
dependencies maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hypnosphi @ndelangen