No unused locals in tsconfig to disable deepscan #20012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deep scan is not compatible with TS 4.9 yet. And the only issues it seems to find that are not covered yet by TS or ESLint are unused imports. TSC can catch those by enabling noUnusedLocals in tsconfig.
|
@ndelangen I split this off the TS 4.9 templates PR: I think we can remove deepscan when this is in. |
ndelangen
approved these changes
Nov 29, 2022
kasperpeulen
deleted the
kasper/sb-1029-no-unused-locals-in-tsconfig-to-disable
branch
|
@kasperpeulen I removed deepscan from the org! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep scan is not compatible with TS 4.9 yet. And the only issues it seems to find that are not covered yet by TS or ESLint are unused imports. TSC can catch those by enabling noUnusedLocals in tsconfig.