Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: improve inDevelopment mode for yarn task #20067

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Build: improve inDevelopment mode for yarn task #20067

merged 8 commits into from
Dec 2, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 2, 2022 •
edited by JReinhold
Loading

Issue: N/A

What I did

This PR improves the yarn task --task sandbox command:

  1. ignores repro templates with inDevelopment in CI.
  2. support a debug flag, that adds more logging in some places

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Dec 2, 2022
@yannbf yannbf merged commit 324c338 into next Dec 2, 2022
@yannbf yannbf deleted the fix/in-development-flag branch December 2, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yannbf @JReinhold