Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next #20106

Merged
merged 2 commits into from Dec 6, 2022
Merged

Fix next #20106

merged 2 commits into from Dec 6, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 6, 2022 •
edited

Issue: CI on next is broken:
https://circleci.com/gh/storybookjs/storybook/451742

What I did

I added a CLI flag to the call the sb init so it knows the project is html when the template's expected renderer is html

@ndelangen ndelangen self-assigned this Dec 6, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Dec 6, 2022
@ndelangen ndelangen added the ci:merged Run the CI jobs that normally run when merged. label Dec 6, 2022
@ndelangen ndelangen changed the title add a flag to the sb init when the expected renderer is html, so the cli knows what project type it is. Fix next Dec 6, 2022
@ndelangen ndelangen merged commit 118a3ae into next Dec 6, 2022
@ndelangen ndelangen deleted the fix/next-sb-init-ci branch December 6, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndelangen