Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Migrate @storybook/web-components-vite to strict TS #22309

Merged
merged 2 commits into from
May 1, 2023
Merged

Build: Migrate @storybook/web-components-vite to strict TS #22309

merged 2 commits into from
May 1, 2023

Conversation

usrrname
Copy link
Contributor

Part of #22176

What I did

lint(tsconfig.json): change compilerOptions.strict from false => true

How to test

  1. ensure I'm using node 16
  2. yarn task --task compile --no-link --start-from=install
  3. cd into code/frameworks/web-components-vite/
  4. Run yarn check

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@usrrname usrrname force-pushed the 22176-web-components-vite-strict-ts branch 4 times, most recently from cfc2a02 to 44e6239 Compare April 30, 2023 14:46
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label May 1, 2023
@kasperpeulen kasperpeulen self-assigned this May 1, 2023
@kasperpeulen kasperpeulen self-requested a review May 1, 2023 14:07
kasperpeulen
kasperpeulen approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen merged commit 51f7cd7 into storybookjs:next May 1, 2023
11 checks passed
@usrrname usrrname deleted the 22176-web-components-vite-strict-ts branch May 1, 2023 14:34
@kasperpeulen kasperpeulen mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@usrrname @kasperpeulen