Build: Migrate @storybook/channel-websocket to strict TS #22364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
requested changes
May 3, 2023
| @@ -20,9 +20,9 @@ interface CreateChannelArgs { | |||
| } | |||
|
|
|||
| export class WebsocketTransport { | |||
| private socket: WebSocket; | |||
| private socket?: WebSocket; | |||
There was a problem hiding this comment.
I would prefer inlining the connect function in the constructor, to show TS that it is always defined. As it is private, it is really only used in the constructor anyway.
Comment on lines
72
to
74
| if (this.handler) { | ||
| this.handler(event); | ||
| } |
There was a problem hiding this comment.
I think we expect a handler to be set here. Could you do a runtime assertion with tiny-invariant?
invariant(this.handler, "WebsocketTransport handler should be set");
kasperpeulen
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Migrate @storybook/channel-websocket to strict-ts
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]