Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Angular Prerelease sandbox #22379

Merged
merged 2 commits into from
May 4, 2023
Merged

Add Angular Prerelease sandbox #22379

merged 2 commits into from
May 4, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 3, 2023 •
edited
Loading

Closes N/A

What I did

Added Angular Prerelease sandbox

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added maintenance User-facing maintenance tasks ci:daily Run the CI jobs that normally run in the daily job. labels May 3, 2023
yannbf
yannbf approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels May 4, 2023
@valentinpalkovic valentinpalkovic merged commit 7e57324 into next May 4, 2023
18 of 19 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/add-angular-prerelease-sandbox branch May 4, 2023 09:43
@valentinpalkovic valentinpalkovic added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinpalkovic @yannbf