Build: move deprecated packages #22753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
build
ndelangen
force-pushed
the
norbert/move-builders
branch
from
f408d70
to
1241545
Compare
ndelangen
force-pushed
the
norbert/move-shims
branch
from
9fe72e9
to
5d604f3
Compare
ndelangen
force-pushed
the
norbert/move-shims
branch
from
5d604f3
to
b9c3d16
Compare
ndelangen
force-pushed
the
norbert/move-shims
branch
from
c33c7e5
to
13fd921
Compare
JReinhold
approved these changes
May 26, 2023
|
Like I mentioned in the other PR as well... I think those are not maintained at the moment, and don't work. But updating those lockfiles would be waste of my time, for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved 6 packages into their own subdir (a child directory of
code) for organizational purposes.The 6 packages I moved:
lib/client-api➡️deprecated/client-apilib/preview-web➡️deprecated/preview-weblib/addons➡️deprecated/addonslib/core-client➡️deprecated/core-clientlib/manager-api-shim➡️deprecated/manager-api-shimlib/store➡️deprecated/storeHaving the deprecated packages will make it so they are not a distraction when coding on other
lib/*packages.Any code-changes in this PR are only to make tools such as eslint, etc, and CI understand where the code moved to.