Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: upgrade cross-spawn to 6.0.3 #2854

Merged
merged 3 commits into from Feb 20, 2018
Merged

CLI: upgrade cross-spawn to 6.0.3 #2854

merged 3 commits into from Feb 20, 2018

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 27, 2018

Issue: #2815

The only breaking change is dropping support for node < 4, which we don't seem to support anyway


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #2854 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2854      +/-   ##
=========================================
- Coverage   37.48%   37.3%   -0.18%     
=========================================
  Files         434     435       +1     
  Lines        9389    9432      +43     
  Branches      894     883      -11     
=========================================
  Hits         3519    3519              
- Misses       5318    5379      +61     
+ Partials      552     534      -18
Impacted Files Coverage Δ
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
lib/core/src/client/preview/reducer.js 37.5% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/index.js 74.35% <0%> (ø) ⬆️
lib/core/src/server/build-dev.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f5682...3ab1b1a. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team February 15, 2018 11:54
@Hypnosphi Hypnosphi merged commit bdbf6f8 into master Feb 20, 2018
@Hypnosphi Hypnosphi deleted the upgrade-cross-spawn branch February 20, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants