Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should core-packet-smpte_2108_1.c be linked in? #78

Closed
TriveniSean opened this issue Oct 26, 2023 · 2 comments
Closed

Should core-packet-smpte_2108_1.c be linked in? #78

TriveniSean opened this issue Oct 26, 2023 · 2 comments

Comments

@TriveniSean
Copy link

TriveniSean commented Oct 26, 2023

I was just messing around with an MSYS2 build and I noticed that the meson.build didn't reference core-packet-smpte_2108_1.c

ld.exe: src/libklvanc.dll.p/core-packets.c.obj:core-packets.c:(.rdata+0x3a8): undefined reference to 'parse_SMPTE_2108_1' ld.exe: src/libklvanc.dll.p/core-packets.c.obj:core-packets.c:(.rdata+0x3b0): undefined reference to 'klvanc_dump_SMPTE_2108_1'

The linker was grumpy until I added it.

@dheitmueller
Copy link
Contributor

@TriveniSean Thanks for the feedback. Yes, the file should be added to the meson file. The Meson spec was contributed by a third-party and isn't part of our standard build process, so stuff like this sometimes gets overlooked.

@dheitmueller
Copy link
Contributor

The fix for this is in #76 and should be merged. After merge this bug can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants