configure requires well added to Makefile.PL and META.* files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! btw, this reminds me that plotly now has kaleido. I probably can get some time to write a Alien::Plotly::Kaleido hopefully in the next couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃槃
I have trouble to install Alien::Plotly::Orca due to a prereq issue (see this failed build.
I propose this change, that adds well the configure requires to Makefile.PL and META.*.
It's probably a bit overkill and we could also imagine changing the
require File::Copy::Recursiveperrequires 'File::Copy::Recursive' => '0';in the share block (here : https://github.com/thibaultduponchelle/perl5-Alien-Plotly-Orca/blob/master/alienfile#L102) and also the same forPath::Tinybut configure requires is working fine :)/cc @plicease
Best regards.
Thibault