Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Update to v0.46 #21

Closed
okwme opened this issue Apr 26, 2022 · 5 comments
Closed

Update to v0.46 #21

okwme opened this issue Apr 26, 2022 · 5 comments

Comments

@okwme
Copy link
Contributor

okwme commented Apr 26, 2022

module needs to be updated to v0.46 for Rho upgrade.
current work in cosmos/gaia#1436 blocked by this.
IG hub team will try updating but might need support

@jtieri
Copy link
Member

jtieri commented Apr 26, 2022

Tried bumping the dep for the SDK to v0.46.0-beta2 but looks like ibc-go v3 imports some things that are no longer present in 0.46 line of the SDK.

Here are some logs from after bumping the dep in go.mod and attempting to go mod tidy

github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/apps/transfer/types tested by
        github.com/cosmos/ibc-go/v3/modules/apps/transfer/types.test imports
        github.com/tendermint/tendermint/state: module github.com/tendermint/tendermint@latest found (v0.35.4), but does not contain package github.com/tendermint/tendermint/state
github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types tested by
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types.test imports
        github.com/cosmos/ibc-go/v3/testing/simapp imports
        github.com/cosmos/cosmos-sdk/x/auth/ante: package github.com/cosmos/cosmos-sdk/x/auth/ante provided by github.com/cosmos/cosmos-sdk at latest version v0.45.4 but not at required version v0.46.0-beta2
github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types tested by
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types.test imports
        github.com/cosmos/ibc-go/v3/testing/simapp imports
        github.com/cosmos/cosmos-sdk/x/auth/client/rest: package github.com/cosmos/cosmos-sdk/x/auth/client/rest provided by github.com/cosmos/cosmos-sdk at latest version v0.45.4 but not at required version v0.46.0-beta2
github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types tested by
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types.test imports
        github.com/cosmos/ibc-go/v3/testing/simapp imports
        github.com/cosmos/ibc-go/v3/modules/core/02-client/client imports
        github.com/cosmos/cosmos-sdk/types/rest: package github.com/cosmos/cosmos-sdk/types/rest provided by github.com/cosmos/cosmos-sdk at latest version v0.45.4 but not at required version v0.46.0-beta2
github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types tested by
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types.test imports
        github.com/cosmos/ibc-go/v3/testing/simapp imports
        github.com/cosmos/ibc-go/v3/modules/core/02-client/client imports
        github.com/cosmos/cosmos-sdk/x/gov/client/rest: package github.com/cosmos/cosmos-sdk/x/gov/client/rest provided by github.com/cosmos/cosmos-sdk at latest version v0.45.4 but not at required version v0.46.0-beta2
github.com/strangelove-ventures/packet-forward-middleware/v2/router imports
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types tested by
        github.com/cosmos/ibc-go/v3/modules/core/04-channel/types.test imports
        github.com/cosmos/ibc-go/v3/testing/simapp imports
        github.com/cosmos/ibc-go/v3/testing/simapp/params imports
        github.com/cosmos/cosmos-sdk/x/auth/legacy/legacytx: package github.com/cosmos/cosmos-sdk/x/auth/legacy/legacytx provided by github.com/cosmos/cosmos-sdk at latest version v0.45.4 but not at required version v0.46.0-beta2

@DavidNix
Copy link
Contributor

Following up because of renewed interest in this problem.

TLDR; I still get the same error.

Cosmos SDK v0.46.0-beta2 is still the latest release for v0.46.

This beta2 release removed the packages:

  • github.com/cosmos/cosmos-sdk/x/gov/client/rest
  • github.com/cosmos/cosmos-sdk/x/auth/client/rest
  • github.com/cosmos/cosmos-sdk/x/auth/legacy/legacytx
  • github.com/cosmos/cosmos-sdk/x/auth/ante
  • github.com/cosmos/cosmos-sdk/types/rest

However, ibc-go/v3 still depends on the above packages. And this repo, packet-forward-middleware, depends on ibc-go/v3.

My recommendation is ibc-go/v3 needs to update to remove dependencies the deleted cosmos packages. I checked tip of upstream, and unfortunately these packages are still in use by ibc-go.

We could fork ibc-go/v3 but we risk destabilizing the ibc modules.

@DavidNix
Copy link
Contributor

@boojamya fyi ☝️

@DavidNix
Copy link
Contributor

@jtieri
Copy link
Member

jtieri commented Aug 1, 2022

Updated to SDK v0.46.0 in a branch that I will open a PR from. This will update the Tendermint version, the ibc-go version, as well as the Go version to 1.18.

@jtieri jtieri closed this as completed Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants