Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why write an article for a broken code base? #84

Closed
mikepuerto opened this issue Apr 4, 2019 · 5 comments
Closed

Why write an article for a broken code base? #84

mikepuerto opened this issue Apr 4, 2019 · 5 comments

Comments

@mikepuerto
Copy link

I did not feel any of the questions were relevant to my "issue" I'm just curious as to why This article on Medium is NO WHERE near accurate to: nextjs-react-strapi-deliveroo-clone-tutorial ?

These sorts of things just throw people off as I'm sure you can tell by all the comments. Being that this is an "official" strapi article, it only makes sense that you properly write the article and don't leave steps out that appear to be sending everyone for a loop.

@Pedrock
Copy link

Pedrock commented Apr 15, 2019

And it has no back-end validation of the payment with Stripe: huge vulnerability!

@soupette
Copy link
Contributor

@mikepuerto I agree we are rewriting these articles at the moment!

@Palgie
Copy link

Palgie commented Sep 6, 2019

@soupette Thanks for revisiting these articles. If I could I'd like to put these two ideas forward for the refresh:

  • Back-end validation of the payment from Stripe (as @Pedrock mentioned).
  • Syncing product records to Stripe to use alongside Stripe Orders API rather than simple Stripe Transactions (Maybe a good way to demonstrate using Strapi lifecycle updates to mirror create / update)

Think these would make a great difference to the end result due to the added benefits.

Excited to see the see the new articles and source!

@krynv
Copy link

krynv commented Nov 7, 2019

Have these been rewritten & submitted anywhere yet?

@8kigai
Copy link

8kigai commented Nov 26, 2019

I don't feel like the authentication and authorization should be written like this. Some of the code just don't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants