fix(waiter): Increase timeout to 2hr and wait in parallel #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdial89f
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
## [2.1.1](v2.1.0...v2.1.1) (2023-04-20) ### Bug Fixes * **waiter:** Increase timeout to 2hr and wait in parallel ([#231](#231)) ([ca228db](ca228db))
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This changeset increases the waiter timeout to a max of 2hr (default custom resource timeout) and waits for stack deletion in parallel.
Linked Issues to Close
Closes #218
Approach
The timeout passed to cloudformation is now 7200s (2hr). We put the calls to wait in an array and wait in parallel with Promise.all()
Learning
None
Assorted Notes/Considerations
None