Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting minHeight and minWidth on placeholder div #21

Open
TheodorTomas opened this issue Dec 4, 2018 · 1 comment
Open

Enable setting minHeight and minWidth on placeholder div #21

TheodorTomas opened this issue Dec 4, 2018 · 1 comment

Comments

@TheodorTomas
Copy link

Do you want to request a feature or report a bug?
feature

What is the current behaviour?

Defaults to 1px for minWidth and minHeight.

Desired behaviour

It would be a nice feature to be able to set the minWidth and minHeight by sending in arguments. Using a className does not suffice in all use cases.

I would be happy to contribute to this feature if this is something you would like to add to the library.

@tazsingh
Copy link
Member

Thanks for the recommendation!

Per my suggestion here: #17 (comment)

Do you think this could be added as a global option? Or in a more fine-grained per-loadable approach?

Also could you kindly elaborate as to how the className doesn't fit the use case such that I can understand it better? My understanding is that the className could work with a fine-grained per-loadable approach but may be annoying to pass in every time if you want it for a global use case?

Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants