Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if dbus-rs emits InterfaceChanged signals properly #1377

Closed
Tracked by #140
agrover opened this issue Dec 19, 2018 · 3 comments · Fixed by #2170
Closed
Tracked by #140

Investigate if dbus-rs emits InterfaceChanged signals properly #1377

agrover opened this issue Dec 19, 2018 · 3 comments · Fixed by #2170
Assignees
Projects

Comments

@agrover
Copy link
Contributor

agrover commented Dec 19, 2018

Even if our objects do not dynamically change interfaces, InterfaceAdded is the signal that should be emitted when an object is added to the set of object available via GetManagedObjects, and vice-versa for InterfaceRemoved.

We discussed using multiple interfaces to indicate a pool gaining or losing capabilities based on its state. In order to work, changing interfaces should (automatically) cause InterfaceChanged events to be generated. We need to verify this is the case before going much further in investigating this as part of our stable API plans. We are not yet in a situation where we need to change interfaces on our objects.

@agrover agrover added this to the Stratis 1.1 milestone Dec 19, 2018
@agrover agrover added this to To Do in Stratis 1.1 via automation Dec 19, 2018
@agrover
Copy link
Contributor Author

agrover commented Dec 19, 2018

Correction: The signals are InterfacesAdded and InterfacesRemoved.

@agrover
Copy link
Contributor Author

agrover commented Dec 19, 2018

I see a little on the client side of dbus-rs maybe, but nothing on the server side to generate these signals. There are some discouraging comments above fn object_manager() around line 651 in methoddisp.rs.

@mulkieran mulkieran removed this from the Stratis 1.1 milestone Jul 20, 2020
@mulkieran mulkieran added this to To do in 2020July via automation Jul 20, 2020
@mulkieran mulkieran removed this from To Do in Stratis 1.1 Jul 20, 2020
@mulkieran mulkieran self-assigned this Jul 20, 2020
@mulkieran mulkieran moved this from To do to In progress (long term) in 2020July Jul 21, 2020
@mulkieran mulkieran assigned jbaublitz and unassigned mulkieran Jul 21, 2020
@mulkieran
Copy link
Member

@jbaublitz it's all yours.

@mulkieran mulkieran moved this from In progress (long term) to In progress in 2020July Jul 27, 2020
2020July automation moved this from In progress to Done Aug 9, 2020
@mulkieran mulkieran reopened this Aug 9, 2020
@mulkieran mulkieran added this to To do in 2020August via automation Aug 9, 2020
@mulkieran mulkieran removed this from Done in 2020July Aug 9, 2020
@mulkieran mulkieran moved this from To do to In progress in 2020August Aug 9, 2020
2020August automation moved this from In progress to Done Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2020August
Done (1)
3 participants