Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate transformation works only with FieldPositionKeys #710

Open
fhueske opened this issue Apr 22, 2014 · 3 comments
Open

Aggregate transformation works only with FieldPositionKeys #710

fhueske opened this issue Apr 22, 2014 · 3 comments

Comments

@fhueske
Copy link
Contributor

fhueske commented Apr 22, 2014

In the new Java API, Aggregate transformations can only be applied to DataSets that are grouped using field positions and to ungrouped DataSets.
DataSets grouped with KeySelector functions are not supported.

Since Aggregations only work on Tuple DataSets which can be grouped using the more convenient field positions, this might be OK.
Or should we support KeySelector groupings as well for completeness?

Opinions?

@fhueske fhueske added this to the Release 0.5 milestone Apr 22, 2014
@markus-h
Copy link
Contributor

In my opinion it is enough to support aggregrations with tuple fields and field positions only. I cannot think of an usecase where key selectors on tuples are more convenient.

@StephanEwen
Copy link
Contributor

It would be nice, but I think this has rather low priority. We should give a good error message, though.

@fhueske
Copy link
Contributor Author

fhueske commented Apr 24, 2014

I added an error msg in #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants