Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT watchlist causes table hit for ARP and LLDP pkt #97

Closed
ccascone opened this issue Oct 3, 2020 · 0 comments · Fixed by #99
Closed

INT watchlist causes table hit for ARP and LLDP pkt #97

ccascone opened this issue Oct 3, 2020 · 0 comments · Fixed by #99
Assignees
Labels
bug Something isn't working

Comments

@ccascone
Copy link
Member

ccascone commented Oct 3, 2020

The watchlist is designed to match only on IPv4 flows. This is probably happening because of PHV conflicts (arp/lldp fields ending up in ipv4/udp/tcp fields).

We should update the watchlist table to either:

  • match on ipv4 validity bit
  • wrap table apply with gateway condition (if (hdr.ipv4.isValid()) watchlist.apply())

We should check all the other tables in the pipeline. Do we check header validity when matching certain fields?

I wish the compiler would be capable of emitting warnings for such conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants