Invalid error code on P4RT write request with unknown device ID

[pudelkoM]

According to the spec, Stratum should return NOT_FOUND, not INVALID_ARGUMENT, in this case:

If device_id does not match any of the devices known to the P4Runtime server or if role does not match any of the roles for the device, the server must return a NOT_FOUND error.

stratum/stratum/hal/lib/common/p4_service.cc

Lines 300 to 304 in 5dbb452

	uint64 node_id = req->device_id();
	if (node_id == 0) {
	return ::grpc::Status(::grpc::StatusCode::INVALID_ARGUMENT,
	"Invalid device ID.");
	}

[yi-tseng-intel]

I guess we can close this since #1000 is merged?

[pudelkoM]

I think that PR addressed it inside the switch impls, but P4Service still returns the wrong code?

[yi-tseng-intel]

I think that PR addressed it inside the switch impls, but P4Service still returns the wrong code?

Ah, right, I think I missed that part.