Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in optimizer docs for strawberry.django.type annotation #334

Conversation

fireteam99
Copy link
Contributor

Description

The correct annotation should be @strawberry.django.type and not @strawberry.django. Otherwise you will get a "module is not callable" error.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The correct annotation should be `@strawberry.django.type` and not `@strawberry.django`. Otherwise you will get a "module is not callable" error.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e55ba3) 87.90% compared to head (1bb791f) 87.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          33       33           
  Lines        2944     2944           
=======================================
  Hits         2588     2588           
  Misses        356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for that! :)

@bellini666 bellini666 merged commit 981fb93 into strawberry-graphql:main Aug 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants