Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #424, really push OR, AND and NOT to the end #435

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Dec 6, 2023

Fix for #432

really and only push AND, OR and NOT to the end.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (518fd8e) 87.27% compared to head (88dd5ca) 87.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files          37       37           
  Lines        3127     3127           
=======================================
  Hits         2729     2729           
  Misses        398      398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! :)

@bellini666 bellini666 merged commit 503dd5e into strawberry-graphql:main Dec 6, 2023
54 checks passed
@devkral
Copy link
Contributor Author

devkral commented Dec 6, 2023

thanks, note: sorting should be only used in emergencies as it has a bad performance.

There should be maybe an evaluation where sorting is used and not cached or where user input is sorted (risk of denial of service, therefor just pushing NOT, AND and OR back). But this is another topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manually using strawberry_django.filters.apply does not work anymore after v0.27
3 participants