Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album cover disk cache cannot distuingish between album names #4 and #5 #1183

Closed
3 tasks done
MausGames opened this issue Apr 18, 2023 · 3 comments
Closed
3 tasks done

Comments

@MausGames
Copy link

MausGames commented Apr 18, 2023

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
I have two albums in my collection named #4 and #5. When the album cover disk cache is enabled, both albums cannot have separate covers. Looking at the cache files, it seems the album name is used as key and points to the same file for both albums.

To Reproduce
Enable disk cache, have two separate albums named #4 and #5, and give them separate album covers. Initially the covers are separate, but after some time using the application (cache refresh ?) both covers become identical.

Expected behavior
Both albums have separate covers.

Screenshots:
image

System Information:

  • Operating System:
    Fedora Linux 37
    KDE Plasma Version: 5.27.4
    KDE Frameworks Version: 5.104.0
    Qt Version: 5.15.8
    Kernel Version: 6.2.9-200.fc37.x86_64 (64-bit)
    Graphics Platform: X11
    Processors: 12 × AMD Ryzen 5 3600XT 6-Core Processor
    Memory: 31,2 GiB of RAM
    Graphics Processor: AMD Radeon RX 5600 XT
  • Strawberry Version:
    1.0.16 (Qt 5.15.8)

Additional context
Show: Entire Collection
Group by: Group by Album
no cover providers are enabled, covers are manually in album folders
it seems to work with disabled disk cache

@jonaski
Copy link
Member

jonaski commented Apr 18, 2023

I can't reproduce this, but I'm pretty sure it's related to disk cache keys not being URL encoded, so b0b8ff2 should probably fix it.

@MausGames
Copy link
Author

Thank you! I will give you an update when I get the fix. (which might take a bit, as I use the Fedora build)

@MausGames
Copy link
Author

MausGames commented Jun 13, 2023

I did not know that there are experimental developer builds available, so I've downloaded 1.0.17.144 and was able to confirm that the issue is fixed.

The disk cache became a bit bigger at first (4.7 MB), but after clearing it and using the software for some time, everything was back to normal and was still working (2 MB).

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants