Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check stream.headers for options #21

Closed
jonathanong opened this issue Jun 12, 2014 · 6 comments
Closed

check stream.headers for options #21

jonathanong opened this issue Jun 12, 2014 · 6 comments
Assignees
@dougwilson
Labels
enhancement

Comments

@jonathanong
Copy link
Contributor

the primary reason i didn't do this before because of content-encoding, but if we handle content-encoding we could just grab all necessary info from stream.headers, if available.

i'm sure they'll be edge cases if people do crazy shit...
@jonathanong jonathanong mentioned this issue Jun 12, 2014
Closed
@jonathanong jonathanong changed the title check options for .headers check stream.headers for options Jun 12, 2014
@dougwilson
Copy link
Member

i'm sure they'll be edge cases if people do crazy shit...

perhaps this module should just accept req instead of any stream? idk

@dougwilson
Copy link
Member

basically i.m.o. if it looks into stream.headers, it would become more of a module specific to req, rather than the generic stream it is now. that's why i liked having the module above this one glue inflation instead of raw-body doing it, idk.

@jonathanong
Copy link
Contributor Author

Yeah we could have something on top and put it in the express org

@dougwilson
Copy link
Member

Yea, that would probably be... body-parser :D especially when i change it to let you build your own parser. then it's basically be your own shell to inflation + raw-body and such.

@dougwilson dougwilson self-assigned this Jun 14, 2014
@jonathanong
Copy link
Contributor Author

what's your opinion on this now?

@dougwilson
Copy link
Member

Close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougwilson dougwilson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougwilson @jonathanong