fix: look for exports.require in package.json in addition to main when patching require
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylannil
changed the title
|
@G-Rath would you review this PR? |
|
We're not able to do releases until @streamich updates the npm token per #381 - note though you shouldn't be updating the version in |
|
@G-Rath Change in package.json version has been reverted. |
G-Rath
approved these changes
Sep 25, 2023
G-Rath
changed the title
exports.require in package.json in addition to main when patching require
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## [1.0.5](v1.0.4...v1.0.5) (2023-09-25) ### Bug Fixes * look for `exports.require` in `package.json` in addition to `main` when patching `require` ([#378](#378)) ([411b791](411b791))
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENV:
require('tiny-lru')PACKAGE.JSON PART:
{ "main": "dist/tiny-lru", "exports": { "types": "./lru.d.ts", "import": "./dist/tiny-lru.js", "require": "./dist/tiny-lru.cjs" }, }the
mainfield is an ESModule，requireneedexports.requiredata to load module in CommonJS.Resolves #378