Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reconfigure GitHub workflows #2082

Merged
merged 6 commits into from Sep 2, 2021
Merged

chore: Reconfigure GitHub workflows #2082

merged 6 commits into from Sep 2, 2021

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Aug 31, 2021

Description

This PR addresses #2080 (review).

The yaml is inspired by gicentre/prettier-plugin-elm.github/workflows/check-codebase.yml.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • xNew feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)
  • Chore (CI updates)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@kachkaev kachkaev changed the title Reconfigure GitHub workflows chore: Reconfigure GitHub workflows Aug 31, 2021
@streamich
Copy link
Owner

Maybe, let's drop Windows? It takes too long:

image

@kachkaev kachkaev marked this pull request as ready for review August 31, 2021 22:39
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@kachkaev
Copy link
Contributor Author

kachkaev commented Aug 31, 2021

Yeah yarn install is not the fastest on Windows. I removed it from the MVP for now, it it might be worth re-adding this OS to later for robustness (at least Node LTS). The install might get faster once we’ve upgraded all project deps. I suspect that we’re dealing with some binary package that is built on the fly — 4 minutes for yarn install is quite a lot 🤔

Happy to bring Windows back now if you’ve changed your mind 🙂

@streamich
Copy link
Owner

Happy to bring Windows back now if you’ve changed your mind 🙂

Let's remove it for now, we can always add it later if there is need.

@kachkaev
Copy link
Contributor Author

👍 Done in 2cc1983

@streamich
Copy link
Owner

👍 Done in 2cc1983

Great, you should be able to merge it.

@kachkaev
Copy link
Contributor Author

Thanks! Happy for you to merge the PR – I’m not sure if there is a preferred policy:

Screenshot 2021-09-01 at 00 03 14

I usually have this in the repo settings:
Screenshot 2021-09-01 at 00 04 30

@kachkaev
Copy link
Contributor Author

kachkaev commented Sep 1, 2021

@streamich which merge type would you recommend?

@streamich
Copy link
Owner

streamich commented Sep 2, 2021

@streamich which merge type would you recommend?

Either way is fine, but the final merge should contain the right semantic commits so that semantic-release will automatically release the right version.

If somebody uses semantic Angular-style commits, I would merge using "Merge commit", if not, I would squash and add the right commit type in the squash commit message.

@streamich streamich merged commit b9848ba into master Sep 2, 2021
@streamich streamich deleted the github-workflows branch September 2, 2021 19:46
@streamich
Copy link
Owner

@kachkaev Thanks, good improvement!

@streamich
Copy link
Owner

🎉 This PR is included in version 17.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants