New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reconfigure GitHub workflows #2082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Yeah Happy to bring Windows back now if you’ve changed your mind 🙂 |
Let's remove it for now, we can always add it later if there is need. |
👍 Done in 2cc1983 |
Great, you should be able to merge it. |
@streamich which merge type would you recommend? |
Either way is fine, but the final merge should contain the right semantic commits so that If somebody uses semantic Angular-style commits, I would merge using "Merge commit", if not, I would squash and add the right commit type in the squash commit message. |
@kachkaev Thanks, good improvement! |
🎉 This PR is included in version 17.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR addresses #2080 (review).
The yaml is inspired by gicentre/prettier-plugin-elm → .github/workflows/check-codebase.yml.
Type of change
Bug fix (non-breaking change which fixes an issue)xNew feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as before)Checklist
Add documentationAdd hook's story at StorybookCover changes with testsyarn test
)Provide 100% tests coverageyarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).