fix: useMedia SSR hydration bug with defaultState #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent a React hydration mismatch when a default value is provided by not defaulting to window.matchMedia(query).matches.
streamich
pushed a commit
that referenced
this pull request
Dec 30, 2021
## [17.3.2](v17.3.1...v17.3.2) (2021-12-30) ### Bug Fixes * useMedia SSR hydration bug with defaultState ([#2216](#2216)) ([5c01189](5c01189))
|
🎉 This PR is included in version 17.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix server side render hydration mismatch when a default value is provided to useMedia
Description
Before, in pr #464 when server side rendering a component that used useMedia, the server's initial state would initialize to false, but then when React hydrated this on the client, it would initialize to the result of the media query. This caused bug #1885 because When React hydrates the server render, it may not match the client's state. The React docs have a little more info on why this can lead to perf issues as well.
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).