Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditorConfig require #23

Closed
maxzitron opened this issue Oct 29, 2018 · 4 comments
Closed

EditorConfig require #23

maxzitron opened this issue Oct 29, 2018 · 4 comments
Labels
released

Comments

@maxzitron
Copy link
Contributor

@streamich I think it's good idea to put EditorConfig in this project to make sure all contributors have the same configuration and prevent unnecessary the code formatting change over each PR.

Cheers,
Max
@streamich
Copy link
Owner

Sure, what settings do you want to save there?

@maxzitron
Copy link
Contributor Author

@streamich I have no preference, to be honest. Your current setting would be fine :)

@streamich
Copy link
Owner

I personally use VSCode and would probably commit its .vscode folder, but don't mind EditorConfig being here, too.

@siva-I siva-I mentioned this issue Oct 29, 2018
Merged
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxzitron @streamich