Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useMedia deprecated methods #2526

Open
RobertoSimonini1 opened this issue Oct 31, 2023 · 1 comment
Open

useMedia deprecated methods #2526

RobertoSimonini1 opened this issue Oct 31, 2023 · 1 comment

Comments

@RobertoSimonini1
Copy link

I have forked and cloned the repository to take a look at the 'useMedia' hook and I noticed that we're using methods matchMedia() .addListener() and matchMedia() .removeListener() which are deprecated.

Shouldn't we replace them with methods addEventListener() and removeEventListener()?
@rileyjshaw
Copy link

This appears to have been fixed in e7379f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rileyjshaw @RobertoSimonini1