TypeScript build fails

[j-f1]

I’ve enabled the strict option in my tsconfig.json, and installing this package results in an error because it can’t find types for the useCallbag hook, even though I don’t use that hook. It seems to be trying to import the types for the use-callbag package, which don’t exist. Can you fix this error?

[benneq]

I have similar issues:

Could not find a declaration file for module 'use-callbag'. 
Could not find a declaration file for module 'use-onclickoutside'. 
Could not find a declaration file for module 'react-wait'

Maybe those typings should be a hard dependency for react-use?

[j-f1]

The problem with use-callbag is that it doesn’t even have typings for TS.

[streamich]

This is not a solution, but I think if you import individual hooks like

import myHook from 'react-use/lib/myHook';

it should work, or doesn't it?

[benneq]

Yes this does work, but isn‘t very nice to use

…

Am 31.01.2019 um 15:53 schrieb Va Da ***@***.***>: This is not a solution, but I think if you import individual hooks like import myHook from 'react-use/lib/myHook'; it should work, or doesn't it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[streamich]

Well I'm using that approach, and that's why I haven't seen this TypeScript error and haven't had incentive to fix it, sorry for that 😃

[benneq]

But using this, you won‘t get automatic imports in VSCode ;)

…

Am 31.01.2019 um 16:05 schrieb Va Da ***@***.***>: Well I'm using that approach, and that's why I haven't seen this TypeScript error and haven't had incentive to fix it, sorry for that 😃 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[streamich]

use-callbag and use-onclickoutside are not part of dependencies anymore. Do you still see this error?

[dcporter]

Yes — react-wait is causing problems (looks like it has an @types (here)! 🎉), as are usePermission’s own types (several are not found).

[xobotyi]

@streamich maybe we should exclude react-wait from default export and add react-wait and @types/react-wait to the optionalDependencies?

[streamich]

react-wait types are now re-expoted, it works for me with Webpack.

@dcporter do see errors caused by react-wait when using latest version? What is your setup?

[dcporter]

It's looking very hopeful. I'll close this out once my local project's PR makes it all the way through the pipeline without mishap. Thanks! :D

[dcporter]

Looks good now, I'm able to import hooks from root! This presented as a binary "everything works or everything is broken" situation, so I'm confident that everything is in a stable place now.

Thanks a ton. (I realized that this is not my issue so I can't close it. But @j-f1 can!)