Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bintray account for Streamlink has been rate-limited #1476

Closed
bastimeyer opened this issue Feb 9, 2018 · 18 comments
Closed

Bintray account for Streamlink has been rate-limited #1476

bastimeyer opened this issue Feb 9, 2018 · 18 comments
Labels

Comments

@bastimeyer
Copy link
Member

bastimeyer commented Feb 9, 2018

Hi Streamlink,

Your Bintray account is currently rate-limited due to overuse.

Customer Support should contact you at the earliest to remove the limits from your account. You may also contact them directly at support@jfrog.com.

Regards,
The Bintray Team

I don't know whether the downloads have been abused or not (it doesn't let me see any download statistics on their website), but it looks like we've reached the traffic limit for this month already, and it's just the 9th of February today.

Maybe it's time thinking about a different release model that doesn't force Windows users to download nightlies from an external, auxiliary hoster, just because they want the latest version of a specific plugin. For now, we should add a small note to the download page to tell users to consider downloading a stable release instead of a nightly build, unless they've experienced a bug in the latest version.

As we've already discussed a few months ago (#811), using Github as a hoster for pre-releases could work, but only if we set up a different repo, so that the amount of notifications and spam can be kept down. I don't know though if we would be breaking Github's ToS with that.

Regarding the idea of letting Streamlink update its plugins automatically (#1347), I've already said that I don't think that we should turn Streamlink into a package manager of its own, as there are too many things which need to be taken into account and which also can go wrong. I also doubt that anybody would want to implement this kind of feature here.

My suggestion in order to reduce the number of nightly downloads, is publishing releases more often, in a 14-day schedule or so. This could even be automated, if desired. I don't actively use yt-dl, but they're releasing far more often and are using the calendar versioning scheme. This lets people immediately know how old a release is and if we'd publish a new release every two weeks, the intention of downloading a nightly build gets reduced greatly.

@bastimeyer bastimeyer added the meta label Feb 9, 2018
@gravyboat
Copy link
Member

gravyboat commented Feb 9, 2018

I got this notification as well. I wish bintray had more stats. It seems odd to me that so many people would download for the limited number of plugins that get updated where we would be over for the month, but without more info there's not much we can do there.

I agree that it seems like the best strategy going forward is releasing more regularly. I still don't really like the idea of doing pre-releases on GitHub and have no idea how abuse would work in that situation. Adding a note to mention that users should only download the nightly if something is wrong, as well as not noting the nightly link quite as prominently on the docs might be a good option. As long as we aren't charged I'm not too concerned about hitting the rate limit either, but I'm also biased.

@amurzeau
Copy link
Contributor

amurzeau commented Feb 9, 2018

According to statistics, they are around 137 downloads since February and almost 1000 downloads since 30 days, maybe 1000 is the limit.

Appveyor can keep artifacts on its own, is this option useful for "large" number of downloads ?
Here: https://ci.appveyor.com/project/beardypig/streamlink-4m1xi/build/job/avr1lbq027ssrnj0/artifacts

@bastimeyer
Copy link
Member Author

The last build seems to have failed during the upload of the Windows installers to Bintray:
https://travis-ci.org/streamlink/streamlink/jobs/344938894#L3346
Let's see if this keeps happening...

@thinkpad4
Copy link

With Bintray rate limited where can I get the latest nightly from?

@beardypig
Copy link
Member

@thinkpad4 currently we don't have a solution for nightly builds. It is possible to install python + pip and use the latest version from github (https://streamlink.github.io/install.html#source-code).

@ghost
Copy link

ghost commented Feb 28, 2018

@thinkpad4
You can try the Portable Builder (requires Win7 or later, but maybe works with Vista SP2 too).

@thinkpad4
Copy link

thinkpad4 commented Mar 1, 2018

OK, thanks. I'll use that until a solution for the nightlies is figured out

@thinkpad4
Copy link

Still no solution?

@gravyboat
Copy link
Member

gravyboat commented Mar 28, 2018

@thinkpad4 Not past what beardypig/RosadinTV suggested. If you don't mind my asking why are you using the nightly builds so much?

@thinkpad4
Copy link

I'm not like installing a new nightly every day, it is just after I see a fix for a plugin that I use get added I wanna install it instead of waiting for the next main release

@bastimeyer
Copy link
Member Author

Bintray is becoming more and more unreliable. Every second or third cron job is failing during the bintray upload:
https://travis-ci.org/streamlink/streamlink/jobs/360401930#L2672
https://travis-ci.org/streamlink/streamlink/builds

@back-to
Copy link
Collaborator

back-to commented Apr 8, 2018

Your Bintray account is currently rate-limited due to overuse.

I think it's not about traffic, it's more about a full storage.

What's included in the OSS?

    Universal Support for All Package Types
    1 TB Downloads
    10 GB Storage
    CDN

from https://bintray.com/signup/oss


the last version is 2018.02.09

https://bintray.com/streamlink/streamlink-nightly/streamlink

275
Days between 10 May 2017 - 09 Feb 2018 #897

let's say ~36 MB per exe file

36MB * 275 = 9900 MB

you are at/over 10 GB


is there a way to delete the old files?

@beardypig
Copy link
Member

I have deleted all the old versions, but the upload is still failing. I guess the next step is to contact them.

@beardypig
Copy link
Member

Removing the old versions seems to have fixed it now. I will be updating the deploy script to automatically remove versions older than 30 days so we don't run in to the 10GB limit again (thanks @back-to...)

@thinkpad4 nightlies are back.

@thinkpad4
Copy link

@beardypig YAY, thank you kindly

@bastimeyer
Copy link
Member Author

I think we should remove the streamlink-latest.exe download option. This can sometimes be confusing, like in this case: #1615 (comment)
Since we're not linking directly to the download anymore, I think this shouldn't cause any issues...
@beardypig could you please keep that in mind when you're going to change the bintray deploy script? Thanks!

@beardypig
Copy link
Member

beardypig commented Apr 26, 2018

I already made that change, months ago even ... but never pushed it ;( I'll put together a PR with the fixes today :)

Update: it's actually in the versioneer build number PR #1413 :)

@beardypig
Copy link
Member

This should be resolved as of #1624 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants