-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bintray account for Streamlink has been rate-limited #1476
Comments
I got this notification as well. I wish bintray had more stats. It seems odd to me that so many people would download for the limited number of plugins that get updated where we would be over for the month, but without more info there's not much we can do there. I agree that it seems like the best strategy going forward is releasing more regularly. I still don't really like the idea of doing pre-releases on GitHub and have no idea how abuse would work in that situation. Adding a note to mention that users should only download the nightly if something is wrong, as well as not noting the nightly link quite as prominently on the docs might be a good option. As long as we aren't charged I'm not too concerned about hitting the rate limit either, but I'm also biased. |
According to statistics, they are around 137 downloads since February and almost 1000 downloads since 30 days, maybe 1000 is the limit. Appveyor can keep artifacts on its own, is this option useful for "large" number of downloads ? |
The last build seems to have failed during the upload of the Windows installers to Bintray: |
With Bintray rate limited where can I get the latest nightly from? |
@thinkpad4 currently we don't have a solution for nightly builds. It is possible to install python + pip and use the latest version from github (https://streamlink.github.io/install.html#source-code). |
@thinkpad4 |
OK, thanks. I'll use that until a solution for the nightlies is figured out |
Still no solution? |
@thinkpad4 Not past what beardypig/RosadinTV suggested. If you don't mind my asking why are you using the nightly builds so much? |
I'm not like installing a new nightly every day, it is just after I see a fix for a plugin that I use get added I wanna install it instead of waiting for the next main release |
Bintray is becoming more and more unreliable. Every second or third cron job is failing during the bintray upload: |
I think it's not about traffic, it's more about a full storage.
from https://bintray.com/signup/oss the last version is 2018.02.09 https://bintray.com/streamlink/streamlink-nightly/streamlink
let's say ~36 MB per exe file 36MB * 275 = 9900 MB you are at/over 10 GB is there a way to delete the old files? |
I have deleted all the old versions, but the upload is still failing. I guess the next step is to contact them. |
Removing the old versions seems to have fixed it now. I will be updating the deploy script to automatically remove versions older than 30 days so we don't run in to the 10GB limit again (thanks @back-to...) @thinkpad4 nightlies are back. |
@beardypig YAY, thank you kindly |
I think we should remove the |
I already made that change, months ago even ... but never pushed it ;( I'll put together a PR with the fixes today :) Update: it's actually in the versioneer build number PR #1413 :) |
This should be resolved as of #1624 :) |
I don't know whether the downloads have been abused or not (it doesn't let me see any download statistics on their website), but it looks like we've reached the traffic limit for this month already, and it's just the 9th of February today.
Maybe it's time thinking about a different release model that doesn't force Windows users to download nightlies from an external, auxiliary hoster, just because they want the latest version of a specific plugin. For now, we should add a small note to the download page to tell users to consider downloading a stable release instead of a nightly build, unless they've experienced a bug in the latest version.
As we've already discussed a few months ago (#811), using Github as a hoster for pre-releases could work, but only if we set up a different repo, so that the amount of notifications and spam can be kept down. I don't know though if we would be breaking Github's ToS with that.
Regarding the idea of letting Streamlink update its plugins automatically (#1347), I've already said that I don't think that we should turn Streamlink into a package manager of its own, as there are too many things which need to be taken into account and which also can go wrong. I also doubt that anybody would want to implement this kind of feature here.
My suggestion in order to reduce the number of nightly downloads, is publishing releases more often, in a 14-day schedule or so. This could even be automated, if desired. I don't actively use yt-dl, but they're releasing far more often and are using the calendar versioning scheme. This lets people immediately know how old a release is and if we'd publish a new release every two weeks, the intention of downloading a nightly build gets reduced greatly.
The text was updated successfully, but these errors were encountered: