Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.euronews: fix and rewrite plugin #5064

Merged

Conversation

bastimeyer
Copy link
Member

Fixes #5062

Actually worthy of a plugin removal, because the vast majority of live streams are just embedded youtube streams, so the plugin is just a wrapper plugin except for a few languages and for VODs. And some languages aren't even supported by the plugin, as euronews is using different websites for those languages.

$ echo -e 'from tests.plugins.test_euronews import TestPluginCanHandleUrlEuronews as test\nfor item in test.should_match:print(item)' \
  | python \
  | xargs -P1 -n1 streamlink
[cli][info] Found matching plugin euronews for URL https://www.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://fr.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://de.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://it.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://es.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://pt.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://ru.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://ua.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://tr.euronews.com/live
Available streams: 240p (worst), 360p, 480p, 576p, 720p_alt, 720p (best)
[cli][info] Found matching plugin euronews for URL https://gr.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://hu.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://fa.euronews.com/live
Available streams: 240p (worst), 360p, 480p, 576p, 720p_alt, 720p (best)
[cli][info] Found matching plugin euronews for URL https://arabic.euronews.com/live
Available streams: 144p (worst), 240p, 360p, 480p, 720p (best)
[cli][info] Found matching plugin euronews for URL https://www.euronews.com/video
Available streams: vod (worst, best)
[cli][info] Found matching plugin euronews for URL https://www.euronews.com/2023/01/02/giving-europe-a-voice-television-news-network-euronews-turns-30
Available streams: vod (worst, best)

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jan 2, 2023
@gravyboat
Copy link
Member

Actually worthy of a plugin removal

Do you want to fix it then remove it or just remove it in this PR?

@bastimeyer
Copy link
Member Author

I'm not sure. We can merge this fix, but IMO, this plugin is a bit pointless. It may only be useful if euronews restart their live streams lots of times on YouTube and the IDs switch because of that, but even then it's still a wrapper plugin.

Anyone else's opinion?

@mkbloke
Copy link
Member

mkbloke commented Jan 9, 2023

*Shrugs*

I don't suppose many folks are using this; it's probably been borked for ages.

Could merge it for now and then review the next time an issue is reported?

@bastimeyer bastimeyer merged commit ae75834 into streamlink:master Jan 10, 2023
@bastimeyer bastimeyer deleted the plugins/euronews/fix-and-rewrite branch January 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.euronews: 404 Client Error
3 participants