Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic reconciler metrics #689

Merged
merged 6 commits into from
Sep 19, 2023
Merged

add basic reconciler metrics #689

merged 6 commits into from
Sep 19, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Sep 15, 2023 •
edited

Fixes #655

Motivation

provide health and performance metrics

Modifications

  • add healthz and readyz check
  • add monitoring package
  • add golang runtime metrics
  • add FunctionMeshControllerReconcileCount metrics
  • add FunctionMeshControllerReconcileLatency metrics

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Sep 15, 2023
@freeznet freeznet requested a review from a team as a code owner September 15, 2023 10:28
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 15, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Sep 15, 2023
@freeznet freeznet added type/feature Indicates new functionality doc-info-missing This pr needs to mark a document option in description labels Sep 15, 2023
@github-actions github-actions bot added doc-required This pr needs a document and removed doc-info-missing This pr needs to mark a document option in description labels Sep 15, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@jiangpengcheng
Copy link
Member

the metrics port(8080) is not exposed in the chart, shall we expose it?

@freeznet
Copy link
Member Author

freeznet commented Sep 19, 2023 •
edited

@jiangpengcheng I have exposed the port by service, PTAL when you have time, thanks.

@nlu90 nlu90 merged commit ec754f2 into master Sep 19, 2023
13 checks passed
@nlu90 nlu90 deleted the freeznet/visibility branch September 19, 2023 17:38
@freeznet freeznet mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangpengcheng jiangpengcheng jiangpengcheng approved these changes

@nlu90 nlu90 nlu90 approved these changes

Assignees

@freeznet freeznet

Labels
doc-required This pr needs a document m/2023-09 type/feature Indicates new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] provide health and performance metrics
3 participants
@freeznet @jiangpengcheng @nlu90