Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep messages in the producer until we get the receipt #100

Open
Geal opened this issue Jun 1, 2020 · 1 comment
Open

keep messages in the producer until we get the receipt #100

Geal opened this issue Jun 1, 2020 · 1 comment

Comments

@Geal
Copy link
Collaborator

Geal commented Jun 1, 2020

in case of reconnections, messages previously sent might have been lost, so we should keep them in a queue until we get the send receipt, and if we reconnected, send them again. Before implementing this, we should look at the Java client's implementation and make sure to follow the same semantics

@Geal
Copy link
Collaborator Author

Geal commented Jul 2, 2020

the way it is done right now, we await for the receipt on each message, so there's no queue of messages, only the current message that can be resent after reconnection:
https://github.com/wyyerd/pulsar-rs/blob/1cc9f9a60ea8618c5bc43faff94b22c463aaaa08/src/producer.rs#L461-L495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant