Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] PulsarCtl 1266 Oauth2 Client credentials flow use scopes from the keyfile as well #1244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nikolajls
Copy link

@Nikolajls Nikolajls commented Jul 11, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes streamnative/pulsarctl#1266 which uses the code being touched here.

Motivation

As the issue shows when using Pulsarctl which works with a context as configuration style, Oauth2 is used under the hood.

However the library does not expose any way to inject the context configuration scope value, and then relies on reading that from the keyFile for client_credentials flow.

However that is not being utilized in the current code as the scope value is not read from from the file.

Explain here the context, and why you're making that change. What is the problem you're trying to solve.
To allow the usage of oauth2 with a keyfile in Pulsarctl 3+ which it doesn't right now

Modifications

Describe the modifications you've done.

Alters so reading the keyFile for client credentials also returns the scope value.

The value is then split on spaces, and added to a temporary slice.
After that the value of any additionalScopes that was already in the options is then added to the temp slice as well.
In the end the additionalScopes property on the options is set to the temp slice containing values from previous additionalScopes and the ones from the keyFile.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Nikolajls Nikolajls marked this pull request as ready for review July 15, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: pulsarctl 3.1 branch can't work with client credentials error
1 participant