Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] View doesn't return to previos position after solving challenge #1257

Closed
woj-tek opened this issue Nov 12, 2018 · 9 comments
Closed

[8.4] View doesn't return to previos position after solving challenge #1257

woj-tek opened this issue Nov 12, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@woj-tek
Copy link

woj-tek commented Nov 12, 2018

In un-sticky-gps, after solving some quest the maps jumps to different location. It happens most of the times, but not always, usually with longer quests (type of road)

How to Reproduce

  • select quest (mostly surface type of the road)
  • the view zooms out
  • solve the quest
  • view jumps to different location (it seems it jumps to the start/end of the road) -- it should return to the previous view from which we selected the object

Versions affected
Android 7.1 Nougat
StreetComplete 8.4

@westnordost
Copy link
Member

westnordost commented Nov 12, 2018

It jumps back to the location that you had in view before clicking on the quest.

Edit:
Ah nevermind, that is what you actually would expect. Well, then I cannot reproduce this.
Perhaps there is a misunderstanding. What do you mean with un-sticky-gps?

@matkoniecz
Copy link
Member

Sticky GPS: viewport follows GPS signal

Unsticky: viewport is not following GPS signal

@woj-tek
Copy link
Author

woj-tek commented Nov 12, 2018

@westnordost
https://www.dropbox.com/s/gb06kotnkyfp80d/streetcomplete.mp4?dl=0 - actually you don't have to solve quest - simply leave it's view. As you can see I start from one position (Urrutia street), enter quest view and then after leaving quest view I'm a couple of blocks down/north (train station). It kinda feels that it's related with long objects that forces change of underlying map view (to fit it completely). As for un-sticky-gpg -- I should say "non-sticky" - i.e. I can freely move around the map.

EDIT:
more or less location https://www.openstreetmap.org/relation/1766981#map=17/-38.23239/-72.33389 - maybe it will help with reproducing the issue.

@westnordost
Copy link
Member

That is definitely a bug, but I haven't been able to reproduce it so far.

@woj-tek
Copy link
Author

woj-tek commented Nov 12, 2018

It's quite reproducible for me - I could provide you with logcat if that helps.

@goldfndr
Copy link
Contributor

Steps:

  1. Move map so that quest is in top right or top left corner.
  2. Tap quest.
  3. Wait for quest to show.
  4. Tap back in navigation bar (or equivalent gesture).
  5. Observe that quest icon is no longer in top corner.

@westnordost
Copy link
Member

westnordost commented Nov 13, 2018

Oh right, I was wrong: Only the zoom is reset to the previous zoom, but not the position. The position is not set to something different at all. In your video it zooms to that position because that is the center of the view.

Question is: Would it be an improvement if not only the zoom is reset but also the position? I am not so sure about that.

@rugk
Copy link
Contributor

rugk commented Nov 13, 2018

Would it be an improvement if not only the zoom is reset but also the position?

IMHO, yes. 😄

@woj-tek
Copy link
Author

woj-tek commented Nov 14, 2018

Question is: Would it be an improvement if not only the zoom is reset but also the position? I am not so sure about that.

It would be huuuuge improvement (and this is the gist of this issue). IMHO, current behaviour is just a bug - I can't find any useful case for current behaviour (zoom out and then return zoom level but to completely different location).

@westnordost westnordost self-assigned this Nov 19, 2018
@westnordost westnordost added this to the v9 milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants