Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-site warning should take into account recent locations #1591

Closed
waldyrious opened this issue Oct 2, 2019 · 4 comments
Closed

On-site warning should take into account recent locations #1591

waldyrious opened this issue Oct 2, 2019 · 4 comments
Assignees

Comments

@waldyrious
Copy link
Contributor

I often use StreetComplete when traveling as a passenger on cars and buses, and tend to get the "Are you sure you checked this on-site?" warning quite a lot, e.g. whenever it takes me more than a couple seconds to fill up the quest answer details and the vehicle moves away from the spot meanwhile.

IMO I should not get such a warning if my position has been near that location in the past few minutes.

@waldyrious waldyrious added the bug label Oct 2, 2019
@rugk
Copy link
Contributor

rugk commented Oct 3, 2019

Actually, maybe just save the position, when you open/"start" the quest and then compare it to this one. 😄

…instead of the current one.

@HolgerJeromin
Copy link
Contributor

Open and close positions should be used to compare.
open quest => oh, i am too far away to really see the reality stuff => walk towards => press OK.

@rugk
Copy link
Contributor

rugk commented Oct 4, 2019

Okay, yes, there are use cases for both. So only show that warning when both positions are too far away…

@westnordost westnordost self-assigned this Oct 19, 2019
@westnordost
Copy link
Member

Fair enough, I'll implement it as @rugk suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants