Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for multiple garages #1720

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

smichel17
Copy link
Member

For #1716

@westnordost
Copy link
Member

Hm actually it was deliberate to not act on your suggestion, because I don't know how this additional information would be helpful to remove doubt.

@smichel17
Copy link
Member Author

smichel17 commented Feb 5, 2020

My problem was: "The garage in front of me has two doors and one roof. What should I mark it as?"

  • It did not obviously fit the single garage picture because the single garage picture only has one entrance
  • It did not obviously fit the multiple garages picture because the multiple garages picture has multiple roofs.

There are multiple ways to disambiguate this case. I thought adding a description to the less common case made more sense than adding a description to the common case. The other way that would make sense to me (and take more work) is adding a second door to the single garage picture.

@westnordost
Copy link
Member

But it is good that it does match neither, because in the case described, the user ought to use his judgement (or in doubt, open a note) to either sort this garage as a garage or as a garages: Some garages with 2 doors might correctly be tagged with garage, others with garages.

@smichel17
Copy link
Member Author

the user ought to use his judgement

That's reasonable, but the judgement should be about whether it fits the criteria for single or multiple, not what those criteria are (this is the job of the more-involved OSM community, or in cases where there is not consensus but you still want to offer the quest, yours).

In this case, it seems like the main criteria are having different owners/users/purposes, but those criteria are not mentioned in the quest, so users have to figure that out based on the name and icon.

(or in doubt, open a note)

Maybe this is a personal problem, but I tend to skip quests where in doubt, rather than add a note.
Perhaps the UI could push me towards notes more, but that's a separate issue.

@westnordost
Copy link
Member

Hmm, okay. After all, your addition is 1:1 what is in the wiki, so it should provide the necessary information. Will merge for the next major because it contains new strings.

@westnordost westnordost merged commit ebae10c into streetcomplete:master Mar 3, 2020
@smichel17 smichel17 deleted the garages branch October 10, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants