Bench for bus stops #2073
Merged
Bench for bus stops #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternewman
reviewed
Sep 4, 2020
| or | ||
| (highway = bus_stop and public_transport != stop_position) | ||
| ) | ||
| and physically_present != no and naptan:BusStopType != HAR |
There was a problem hiding this comment.
Ah now I see why you were asking in the other PR. Is it worth pulling this out so it's a common rule across these two bus stop quests and any future ones. Or at least adding comments to both saying to update the other one if it changes.
Or actually TBH all of this filter apart from the bench bit could be common couldn't it?
...src/main/java/de/westnordost/streetcomplete/quests/bus_stop_bench/AddBenchStatusOnBusStop.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
westnordost
reviewed
Sep 4, 2020
...src/main/java/de/westnordost/streetcomplete/quests/bus_stop_bench/AddBenchStatusOnBusStop.kt
Outdated
Show resolved
Hide resolved
westnordost
approved these changes
Sep 4, 2020
…p_bench/AddBenchStatusOnBusStop.kt Co-authored-by: Tobias Zwick <osm@westnordost.de>
westnordost
approved these changes
Sep 4, 2020
|
Ref #1079 |
91! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am bit dubious about usefulness of this quest but it is asked after all reasonable quests were asked in a given region and I want to reduce number of open issues to 100 :)