Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"What can be left here for recycling" should use recycling:glass in the Czech Republic #2123

Closed
kudlav opened this issue Sep 29, 2020 · 12 comments
Assignees
Labels

Comments

@kudlav
Copy link

kudlav commented Sep 29, 2020

Answering "Glass bottles and jars" overrides existing value "recycling:glass=yes" which is in Czech Republic prefered, so this quest destroys properly mapped data.

According to czech general recycling guide we can recycle:
Coloured glass (used for wine, beer, etc.), smashed glass panes of doors or windows, bottles and jars, broken beverage glass.
See https://jaktridit.cz/en/sorting/sorting-waste-properly---coloured-containers/glass

You can see related issue on Osmose project, after discussion in talk-cz the check was disabled for the Czech Republic: osm-fr/osmose-backend#691

How to Reproduce
Example node that will be overridden:
https://www.openstreetmap.org/node/2815619731

Versions affected
Android 10
StreetComplete 23.0

@kudlav kudlav added the bug label Sep 29, 2020
@westnordost
Copy link
Member

westnordost commented Sep 30, 2020

Do all containers accept all kinds of glass? It sounds a bit odd that it would accept window glass, but the slot to throw things in is bottle-shaped.

If not all containers accept all the glass, I would implement that for CZ, both options "Any type of glass" / "glass bottles and jars" are offered in the form. If all accept all types of glass, I'd replace the bottle option with an "Any type of glass" option and also disable the DetermineRecyclingGlass quest for CZ.

@kudlav
Copy link
Author

kudlav commented Sep 30, 2020

Hi, I would prefer dialog for Glass similar to plastics. Typical containers are for any type of glass but there can be smaller one only for bottles as you said.

Screenshot_20200930-133406_StreetComplete

@westnordost
Copy link
Member

westnordost commented Sep 30, 2020 via email

@kudlav
Copy link
Author

kudlav commented Oct 7, 2020

Yes it is or there is just "Glass". But you can put any kind of glass except mirrors and glass from cars so it rather depends on size of container and size of hole.

These two would be mapped as "Any type of glass":
Container big
Container opened

Maybe this is "Only for bottles" container, but I don't know what's written on the top, I will explore that later. But mapping everything as "Any type of glass" would be less harmful than mapping everything as "Only for bottles".
Container opened

@westnordost westnordost self-assigned this Oct 7, 2020
@westnordost
Copy link
Member

Ok, I'll take care of it

@westnordost
Copy link
Member

My plan would be to show a dialog similar to plastic only for Czech Republic for now. If later it appears that all kinds of glass can be recycled in other countries, they will be added to the list for which the behavior is activated.

@FloEdelmann
Copy link
Member

FloEdelmann commented Oct 7, 2020

@westnordost Why only for specific countries though? The DetermineRecyclingGlass quest is shown to all users anyway, so why not merge the quests for all users? It's just one tap more.

@westnordost
Copy link
Member

Because you won't find any normal container in Germany for example that accepts window glass so it does not make sense to display that option - it will only lead to mistaggings from people who don't know better and didn't read what's printed on the container.

@FloEdelmann
Copy link
Member

Okay, but then the DetermineRecyclingGlass also doesn't make sense in Germany, does it?

@westnordost
Copy link
Member

It does, because many containers are incorrectly tagged as glass=yes

@westnordost
Copy link
Member

I decided to not show an option (any glass / glass bottle and jars only) for the same reason why the option is not shown for Germany: Posing it as an option in CZ would be a source of mistakes. If there is really a rare container that does not accept window glass, the user can leave a note. The same for Germany and other countries where the user finds a container that does accept window glass.

@westnordost
Copy link
Member

Screenshot_1602596596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants