Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard doesn't appear when using the time input fields in the opening hours quest #2799

Closed
cyclingcat opened this issue Apr 25, 2021 · 10 comments
Labels
bug help wanted help by contributors is appreciated; might be a good first contribution for first-timers

Comments

@cyclingcat
Copy link

cyclingcat commented Apr 25, 2021

Hi there,

@TurnrDev's comment (#2795 (comment)) inspired me to try it out myself and found out that this issue doesn't occur with each time picker:

How to Reproduce

  • Find an opening hours quest and open the associated time picker.
  • Instead of choosing the time from the time picker, tap on the keyboard icon. A form with two fields (hour/minute) appears.
  • Tap into one of the two fields. You would expect the (numeric) keyboard to appear, but nothing happens. It's impossible to enter a time here, you have to go back to the time picker by tapping on the clock icon.

However, this bug does not appear with the time picker of the post box collecting times quest. Here the keyboard appears as expected.

Versions affected

Tested with two devices with Android 8.1 and 9.0 repectively. SC v31.3 on each.

The cycling cat

@cyclingcat cyclingcat added the bug label Apr 25, 2021
@westnordost
Copy link
Member

I suspect some Android fuckery that needs to be worked around.

@westnordost westnordost added the help wanted help by contributors is appreciated; might be a good first contribution for first-timers label Apr 25, 2021
@cyclingcat
Copy link
Author

After all it's conspicious that one quest shows this bug while another doesn't. Maybe some other participants with different devices and Android flavours/versions could test if they get this effect too?

The cycling cat

@mnalis
Copy link
Member

mnalis commented Apr 26, 2021

I can confirm both points (failure of keyboard to pop up on opening hours quest, but opening normally on postbox collection times quest. On Huawei P30 Pro, EMUI 11 (Android 10), StreetComplete v31.3 (from f-droid)

@riQQ
Copy link
Collaborator

riQQ commented Apr 26, 2021

Same for me, Android 10 / Nokia 2.2 / StreetComplete 31.3

@mnalis
Copy link
Member

mnalis commented Apr 26, 2021

Interestingly, that same SC v31.3 (from f-droid) does not show the keyboard icon at all on older Xiaomi Redmi Note 3 pro with MIUI 10.2 (Android 6.0.1).

But it also shows difference between opening hours and postbox collection times quests: former shows android time picker with 12hour am/pm, and latter show 24hour variant (which was mentioned in some other issue IIRC), even after full uninstall / install SC cycle.

@westnordost
Copy link
Member

But it also shows difference between opening hours and postbox collection times quests: former shows android time picker with 12hour am/pm, and latter show 24hour variant (which was mentioned in some other issue IIRC), even after full uninstall / install SC cycle.

Oh, that's a bug. Can you create a report for that?

@smichel17
Copy link
Member

On Android 7.0 I can't find where there's the option to do keyboard entry at all 🤷
Tapping on the numbers changes between minutes and hours (setting an hour also swaps to minutes).
Date picker for postbox collection quest, in debug version of the app

@westnordost
Copy link
Member

That's a feature that was added only in later android versions

@westnordost
Copy link
Member

It's part of the Android time picker, this is not a widget from STreetComplete. Which is why my earlier comment.

@westnordost
Copy link
Member

Just going to ping @tapetis here as he often knows the correct answer/workaround to Android-related issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted help by contributors is appreciated; might be a good first contribution for first-timers
Projects
None yet
Development

No branches or pull requests

5 participants