-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render power lines on the map #3338
Comments
I haven't investigated the cause of this, but it's one of two things, and for both this issue should be tracked elsewhere:
|
This seems to be quite the virtual issue, if you must make up mock-up-screenshots of the app? Anyway, I don't understand what is the issue of this at all. Shops are also not shown. But their location is when you are asked about it. And that should be enough. Power poles are far apart, your location is shown on the map and SC should be used only on a survey. |
I'm unsure if shops and power poles are comparable here. A shop-quest is very clearly visible within the confines of a building. As much as quests for bike racks can be almost always clearly compared against the road layout. In the above mentioned case, given I was walking along the track that branches off right above the It might be a niche problem, but I can understand OP's intentions. |
Not always! https://www.openstreetmap.org/#map=19/50.07602/19.87570 (one power line unmappeed, only pole marked, one I think terminates there and also there is a power tower). I was testing app with a family member and they answered "metal" for wooden power pole as they spotted power tower, not power pole (and missed distinction). I also have seen wooden pole next to concrete one, but it is also really rare. |
Common, really? I was following the feature request template as best as possible which asks for mockups for improved clarity, if applicable. I made the extra effort to get the point across as best as possible. If you're looking for a real screenshot, I'll add one in this comment.
I only use StreetComplete when doing a survey. But often times power poles are not easily accessible and have to be mapped from a distance. Like standing on the side of the road and looking 100 or 200 meters out into the countryside where the poles are. And from a distance it is easy to distinguish material, but harder to define exact position in relation to the map.
This! When you have 3 or 4 power poles close to another, without other references (because it is all in a I scrolled back to a region I countered such situations This screenshot is of a number of poles in a field, with minimal reference for orientation. And there is another line close-by which is already tagged but this cannot be viewed on the map to prevent tagging mistakes: A makeshift solution is to open the Vespucci app, but that takes more time, the whole reason why I prefer StreetComplete in the first place. I already started looking into the code how the maps are built up and how it can be expanded. It is a new domain to me, but hopefully there are already useful Tangram examples with power lines to reuse.
I'm currently in France, most of the times the lines have a single type, but some times poles of different functions have different materials, or there can be multiple lines close to one another with different materials. |
For map style see https://github.com/streetcomplete/streetcomplete-mapstyle There are some plans to allow more advanced display of things, but this is a huge project. |
Ok, I understand. So I agree it would make sense to at least display power lanes when the quest form is open. This is actually almost possible, but we might want to wait with that until we have explored whether we want to migrate to MapLibre or not. |
Great! I like that refinement. They can still help for orientation but also clutter the view, so I can see a reason to hide them when the quest is inactive.
No problem, I consider this to be a small usability improvement for 1 particular quest, so it has a low priority. |
Perhaps as a maybe-easier-to-implement temporary solution: use the same element filter as the quest, but with the material requirement flipped, to select all power poles in the area, then display them as dots (like collapsed quests) only when the quest form is open. Lines 10 to 14 in 73b577d
The main thing I'm unsure about is how long running the db query for the quests would take / whether we could do it just-in-time as the quest form is opened, or whether it needs to be cached. I think it should be fast enough, since it's a simple query. |
@smichel17 I see your point, but that feels like a hack as it mis-uses other parts of the code for a different purpose. Considering this is a nice to have, I don't think it is worth diverging from the software structure as intended. Let's wait what the map refactoring can bring. |
Use case
When doing the power pole material quest, the quest icons have no reference, they just float in a void, often in a forest or grass landuse. The lack of spatial awareness becomes an issue when some poles are already tagged (could be earlier quest actions), multiple power lines are close to one another and/or other spatial features are missing. Then you become unsure if you are tagging the right pole, or the next one in line.
To illustrate, this is my current view:
![image](https://user-images.githubusercontent.com/7458098/135770596-40e727a4-18cf-437e-a9f4-014581df4f6d.png)
While this can actually be this situation in practice:
![image](https://user-images.githubusercontent.com/7458098/135770650-33af5a0a-180f-4a60-8a10-6aaf54a9a678.png)
Proposed Solution
Render the power lines and power poles on the map.
Similar to how other quests relate to rendered objects, the power pole material quest would benefit if the objects are visualized.
Power lines and power poles are already mapped on the default Openstreetmap.org website, using simple lines and small squares/circles.
More general, I think it is valuable to render the nodes and ways to which the quests relate.
The text was updated successfully, but these errors were encountered: