Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "birdseye" 3d when quest is selected #3397

Closed
smichel17 opened this issue Oct 17, 2021 · 5 comments
Closed

Disable "birdseye" 3d when quest is selected #3397

smichel17 opened this issue Oct 17, 2021 · 5 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@smichel17
Copy link
Member

Use case
Specifically for building quests, when you select them, only the base of the building is highlighted. In birdseye 3d (left), it's difficult to see the vertical "corners" of the house when it's ~centered in the screen. This leads to the impression that the rendered map shows things in the wrong position, at an offset. In full 3d (right), this is not a problem, since the left wall is visible (but, the map automatically switches to birdseye 3d when a quest is selected; in the screenshot, I manually tilted it with a two-finger shove gesture.

sc-birdseye3d-during-quest-selection |||||||||||||||||||||||||||| sc-full-3d-during-quest-selection

Proposed Solution

When a quest is selected, and the map is switched back to flat, also turn off birdseye 3d.

@westnordost
Copy link
Member

What do you mean with "turn off birdseye 3d"?

@smichel17
Copy link
Member Author

smichel17 commented Oct 17, 2021

Switch to full 2d rendering. Basically #2206 but only for when quests are selected.

edit: tangram calls it the flat camera type

@westnordost
Copy link
Member

Okay, this is not going to happen then, since this means that the whole scene is reloaded in tangram-es which leads to a visual jerk, especially on less powerful/old devices.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Oct 17, 2021
@smichel17
Copy link
Member Author

The docs mention that

The flat camera is a shortcut to a view which can be produced by the other two cameras, but is simpler to setup and use

I wonder if we could do the "less simple" route of adjusting whichever camera parameters. Would that be possible without reloading the scene?

@westnordost
Copy link
Member

I don't think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

2 participants