Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Material Design 3 #3650

Closed
westnordost opened this issue Jan 18, 2022 · 6 comments
Closed

Migrate to Material Design 3 #3650

westnordost opened this issue Jan 18, 2022 · 6 comments
Labels
enhancement help wanted help by contributors is appreciated; might be a good first contribution for first-timers

Comments

@westnordost
Copy link
Member

westnordost commented Jan 18, 2022

The dependency com.google.android.material:material:1.5.0 now has support for Material Design 3.

There is some migration to be done for that: https://material.io/blog/migrating-material-3

As far as I understand, Material Design introduces a new look for all the default components starting with Android 12 and gives the user the ability to define some system-wide color schemes. See https://m3.material.io/

Anyone interesting in doing this migration?

@westnordost westnordost added enhancement help wanted help by contributors is appreciated; might be a good first contribution for first-timers labels Jan 18, 2022
@rugk
Copy link
Contributor

rugk commented Apr 6, 2022

I'd be happy to test it (with Android 12 here).

@westnordost
Copy link
Member Author

Best if the one who implemented this also tested this. But it shouldn't be too complicated to do this without much knowledge of the code. Most of it will be a search and replace and following the migration guide linked. Are you interested to do that?

@rugk
Copy link
Contributor

rugk commented Apr 6, 2022

Not yet here, I'll keep it in mind though.

@westnordost
Copy link
Member Author

Uhm, I started migrating, but Material 3 is really ugly...

@westnordost
Copy link
Member Author

westnordost commented Aug 30, 2022

I'll just update the dependency but not migrate to Material 3. The differences are not big, but what is changed looks ugly or decreases usability, e.g.

  • smaller text but bigger padding on buttons decreases readability
  • all buttons are round now, which makes them all look like tags (e.g. the "open" tag on github, see above)
  • but FABs are now mostly rectangular and light-pink. because... 🤷??
  • default background is not white but very light pink... eh 🤷?
  • top (and bottom) navigation also have that light pink background and don't stand out from the rest of the view (I think there is not even a shadow or divider line) at all. What is this trend to remove all dividers, shadows and lines?
  • plus the difference in styles is causing all sorts of subtle glitches I'd need to fix. I don't really wan to invest the time to make work a style that is just less good than the current one.

Maybe some time Google will come up with Material 4 or something.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
@rugk
Copy link
Contributor

rugk commented Sep 2, 2022

What I heard as a good thing about Material Design 3 though is that it can adapt to the color you choose in your system settings, i.e. all apps are also styled somewhat like that. That sounds cool, actually. (without knowing how it works/looks like)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted help by contributors is appreciated; might be a good first contribution for first-timers
Projects
None yet
Development

No branches or pull requests

2 participants