-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AddAcceptsCards quest #3953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Apr 9, 2022
westnordost
reviewed
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the quest graphic to master
app/src/main/java/de/westnordost/streetcomplete/quests/accepts_cards/CardAcceptance.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Zwick <newton@westnordost.de>
westnordost
approved these changes
Apr 18, 2022
westnordost
reviewed
Apr 18, 2022
app/src/main/java/de/westnordost/streetcomplete/quests/accepts_cards/AddAcceptsCards.kt
Outdated
Show resolved
Hide resolved
westnordost
reviewed
Apr 18, 2022
app/src/main/java/de/westnordost/streetcomplete/quests/accepts_cards/AddAcceptsCards.kt
Outdated
Show resolved
Hide resolved
5 tasks
Is there a reason why this was limited to nodes only? |
No, and I will fix it EDIT: fixed Line 16 in 9745ba1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2704
which would be better?
We have already
(active in Sweden for now) but it seems oddly formal to me, but of it is not worse it would be nice for consistency.
@westnordost Are you interested in making an icon? Or should I try making something? (probably cash quest symbol, but on rectangle, within circle of quest icon)
BTW, I am considering extending range of asked places to what similar quests asks:
StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/accepts_cash/AddAcceptsCash.kt
Lines 17 to 49 in 18189f1