Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AddAcceptsCards quest #3953

Merged
merged 9 commits into from
Apr 18, 2022
Merged

Conversation

matkoniecz
Copy link
Member

fixes #2704

Can you pay here with card?

Is card payment accepted here?

which would be better?

We have already

Is cash payment accepted here?

(active in Sweden for now) but it seems oddly formal to me, but of it is not worse it would be nice for consistency.


@westnordost Are you interested in making an icon? Or should I try making something? (probably cash quest symbol, but on rectangle, within circle of quest icon)


BTW, I am considering extending range of asked places to what similar quests asks:

override val elementFilter: String get() {
val amenities = listOf(
"bar", "cafe", "fast_food", "food_court", "ice_cream", "pub", "biergarten",
"restaurant", "cinema", "nightclub", "planetarium", "theatre", "marketplace",
"internet_cafe", "car_wash", "fuel", "pharmacy", "telephone", "vending_machine"
)
val tourismsWithImpliedFees = listOf(
"zoo", "aquarium", "theme_park", "hotel", "hostel", "motel", "guest_house",
"apartment", "camp_site"
)
val tourismsWithoutImpliedFees = listOf(
"attraction", "museum", "gallery"
)
val leisures = listOf(
"adult_gaming_centre", "amusement_arcade", "bowling_alley", "escape_game", "miniature_golf",
"sauna", "trampoline_park", "tanning_salon"
)
val crafts = listOf(
"carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
"electronics_repair", "key_cutter", "stonemason"
)
return """
nodes, ways, relations with
(
(shop and shop !~ no|vacant|mall)
or amenity ~ ${amenities.joinToString("|")}
or leisure ~ ${leisures.joinToString("|")}
or craft ~ ${crafts.joinToString("|")}
or tourism ~ ${tourismsWithImpliedFees.joinToString("|")}
or tourism ~ ${tourismsWithoutImpliedFees.joinToString("|")} and fee = yes
)
and (name or brand) and !payment:cash and !payment:coins and !payment:notes
"""
(which would likely imply extracting this listing to some shared place)

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the quest graphic to master

@matkoniecz matkoniecz marked this pull request as ready for review April 17, 2022 05:58
@westnordost westnordost merged commit e79cca0 into streetcomplete:master Apr 18, 2022
@Cj-Malone
Copy link
Contributor

Is there a reason why this was limited to nodes only?

@matkoniecz matkoniecz deleted the payments branch April 21, 2022 17:55
@matkoniecz
Copy link
Member Author

matkoniecz commented Apr 22, 2022

Is there a reason why this was limited to nodes only?

No, and I will fix it

EDIT: fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What forms of payment are accepted here? (focusing on small businesses in the United States)
4 participants