Do not ask AddAddressStreet quest if addr:substreet or addr:parentstreet are present #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eet are present (and tests)
matkoniecz
approved these changes
Oct 12, 2022
FloEdelmann
reviewed
Oct 12, 2022
app/src/main/java/de/westnordost/streetcomplete/quests/address/AddAddressStreet.kt
Show resolved
Hide resolved
|
Looks fine, thank you! |
FloEdelmann
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (as agreed in #4483 (comment)) skips the
AddAddressStreetquest if eitheraddr:substreetoraddr:parentstreetare already defined, as answering this quest there would likely only lead to more confusing data, instead of actually helping OSM.It also adds tests for checking if those are being ignored.
It compiles, passes the tests and seems to work fine; e.g. it skips for example this building: https://www.openstreetmap.org/way/230252831 (v6) which lacks
addr:street, but hasaddr:substreet(and on which theAddAddressStreetquest was previously being asked):Closes: #4483